Adding support for calling URL with invalid SSL cert #247
Conversation
|
First, you've broken the tests. It's okay, your change can be modified without having to change the tests, please run them before committing anything else. Secondly, the easy way to fix this is to do: import github3
g = github3.GitHubEnterprise(
# ...
)
g._session.verify = FalseAnd this will work for everything. That said, I can see the benefit of this being a parameter that is passed during initialization of a |
|
Ok my bad, let me spend a bit longer than the 2 mins I had to look at it. I ran the tests and had a lot of random failures that didn't look connected but let me have a closer look. Leave it with me :) |
|
The best way to understand if the failing tests are your fault is to run them before you make any changes. |
|
True that - my bad |
|
@davidmoss no worries. Sorry if I seemed angry, I wasn't and am not. I appreciate the work you did in this PR. Thanks for sending it! 🍰 |
Adding support for calling URL with invalid SSL cert
|
It's fine, I read your contributors and README after and you had everything there so was my fault for rushing it out 😃 cheers! |
|
:) I want to get a few more things in before I release the next version (0.10 or 0.9.1), so hopefully working from GitHub will be sufficient for you (for a short period of time). |
When hosting GitHubEnterprise internally there's a greater chance the SSL certificate could be self signed and thus you need to prevent the requests library from validating the SSL certificate. By passing the verify flag through you can control this validation check and prevent:
SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed