8000 Switch deploy methods by apaparazzi0329 · Pull Request #794 · watson-developer-cloud/python-sdk · GitHub
[go: up one dir, main page]
Skip to content

Switch deploy methods #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apaparazzi0329 merged 3 commits into from
Jun 28, 2021
Merged

Switch deploy methods #794

apaparazzi0329 merged 3 commits into from
Jun 28, 2021

Conversation

@apaparazzi0329
Copy link
Contributor
@apaparazzi0329 apaparazzi0329 commented Jun 24, 2021

This branch currently only uploads to test.pypi.org

@apaparazzi0329 apaparazzi0329 requested a review from Mikemosca June 24, 2021 22:14
@lgtm-com
Copy link
lgtm-com bot commented Jun 24, 2021

This pull request fixes 2 alerts when merging 84b4c57 into e151e82 - view on LGTM.com

fixed alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Except block handles 'BaseException'

Mikemosca
Mikemosca approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor
@Mikemosca Mikemosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in deploy don't forget to switch back to workflow_run. For the pypi action you are still going to test.pypi

@codecov-commenter
Copy link
codecov-commenter commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #794 (0d11464) into master (e151e82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #794   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          25       25           
  Lines       31752    31752           
=======================================
  Hits        29032    29032           
  Misses       2720     2720

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e151e82...0d11464. Read the comment docs.

@lgtm-com
Copy link
lgtm-com bot commented Jun 28, 2021

This pull request fixes 2 alerts when merging 0d11464 into e151e82 - view on LGTM.com

fixed alerts:

  • 1 for Wrong name for an argument in a call
  • 1 for Except block handles 'BaseException'

@apaparazzi0329 apaparazzi0329 merged commit 9fa9d6c into master Jun 28, 2021
@watson-github-bot
Copy link
Collaborator
watson-github-bot commented Jun 28, 2021

🎉 This PR is included in version 5.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mikemosca Mikemosca Mikemosca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO NOT MERGE released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@apaparazzi0329 @codecov-commenter @watson-github-bot @Mikemosca
0