Update core package #1096
Update core package #1096
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
============================================
+ Coverage 67.29% 68.14% +0.85%
- Complexity 3070 3153 +83
============================================
Files 658 658
Lines 17315 17315
Branches 945 945
============================================
+ Hits 11652 11800 +148
+ Misses 5261 5148 -113
+ Partials 402 367 -35
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
👍 looks good, tagging phil as well
There was a problem hiding this comment.
Left a couple comments that you can deal with as you see fit.
| { | ||
| "branch": "master", | ||
| "tagFormat": "java-sdk-${version}", | ||
| "debug": true, |
There was a problem hiding this comment.
technically this doesn't need to be here... I think the debug flag is really just used to produce more verbose output in the travis build log (possibly... presumably... :) ).
There was a problem hiding this comment.
Yep, I went ahead and added it just in case this change still isn't it so that I can fix it easier 😬
| "tagFormat": "java-sdk-${version}", | ||
| "debug": true, | ||
| "plugins": [ | ||
| "@semantic-release/changelog", |
There was a problem hiding this comment.
In the go and python cores, I didn't specify a "plugins" field. Instead, the list of plugins are listed in the "prepare" field.
I don't know what the difference is, but I do know that those two repos seems to be working correctly now :)
But the key is to ensure that the "git" plugin is executed last I think after the steps that create commits are finished.
Here's a link to the go core .releaserc file in case you want to take a look at that for comparison purposes:
https://github.com/IBM/go-sdk-core/blob/master/.releaserc
There was a problem hiding this comment.
Yeah I saw that you were doing it a bit differently. The only reason I went with the "plugins" approach is that it seems to be the new standard way to define it, at least according to semantic-release documentation: https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#options
Since we're running npx semantic-release, we should be grabbing the latest version. I'm just a bit worried that some build in the future might grab a major release and remove support for what seems to be the old way of defining things. I tried to still re-arrange the order to match what you've done since that was presumably the issue.
| compile project(':common') | ||
| testCompile project(':common').sourceSets.test.output | ||
| compile 'com.ibm.cloud:sdk-core:7.0.0' | ||
| compile 'com.ibm.cloud:sdk-core:7.1.0' |
There was a problem hiding this comment.
If you end up using the latest version of the generator to generate the upcoming Watson sdk release, you'll need to upgrade to the new major version of the java core (8.0.0) after that is tagged (should be soon). Just a heads up.
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR updates the core SDK package, mainly to fix #1095. Other core changes included in this update can be found here: https://github.com/IBM/java-sdk-core/releases/tag/7.1.0
Besides the core update, I reconfigured the automated release to fix an issue that had been occurring where bumpversion commits were being excluded from
master.