Proposal: runtime.onInvalidated event
#792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94dca27 to
bbfe5ee
Compare
fregante
reviewed
Mar 26, 2025
oliverdunk
requested changes
Mar 26, 2025
7e295ab to
57258f4
Compare
oliverdunk
approved these changes
Mar 26, 2025
57258f4 to
dff9ba7
Compare
rdcronin
approved these changes
Mar 27, 2025
Co-authored-by: rdcronin <rdcronin@users.noreply.github.com>
runtime.onInvalidated event
xeenon
approved these changes
Mar 29, 2025
Rob--W
reviewed
Mar 29, 2025
proposals/runtime_on_invalidated.md
Outdated
|
|
||
| ### Objective | ||
|
|
||
| This event allows extension contexts which stay alive to be notified when the |
There was a problem hiding this comment.
"extension context" is very generic, while this seems to primarily be targeting content scripts. Can we restrict this to content scripts?
There was a problem hiding this comment.
@Rob--W it is generic on purpose as to cover both content scripts and iframed extension contexts on third party websites. These iframes stay alive on some browsers and require this event to handle their state. The objective states contexts which stay alive to exclude extension contexts which get killed on invalidation.
Updated the objective to be more explicit on this behaviour.
Co-authored-by: Timothy Hatcher <timothy@hatcher.name>
Co-authored-by: Timothy Hatcher <timothy@hatcher.name>
Co-authored-by: Timothy Hatcher <timothy@hatcher.name>
Co-authored-by: Rob Wu <rob@robwu.nl>
|
What are the next steps for this PR? Seems to be approved but not merged? |
|
@Rob--W can you do a final review / give approval for this proposal? |
Rob--W
approved these changes
May 30, 2025
github-actions bot
added a commit
that referenced
this pull request
Jun 5, 2025
…idated SHA: ca87c88 Reason: push, by dotproto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jun 5, 2025
…idated SHA: ca87c88 Reason: push, by dotproto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #138 and #789
It introduces a new event which fires in contentScripts and extension frames when the background scripts get invalidated. In the event is a reason property stating the reason for the invalidation.
@bershanskiy @fregante love to hear your feedback.