Upstream Trusted Types enforcement in EnsureCSPDoesNotBlockStringCompilation #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilation - Also update the violation object resource definition.
|
@annevk just so I'm not putting all this spec stuff on your plate, do you know who else might be able to review this? |
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Jul 2, 2024
https://bugs.webkit.org/show_bug.cgi?id=275392 Reviewed by NOBODY (OOPS!). This patch accurately follows the spec for sample clipping in trusted types. Spec: w3c/webappsec-csp#659 * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https.html: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::allowMissingTrustedTypesForSinkGroup const): (WebCore::ContentSecurityPolicy::reportViolation const): (WebCore::ContentSecurityPolicy::setUpgradeInsecureRequests): * Source/WebCore/page/csp/ContentSecurityPolicy.h:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates EnsureCSPDoesNotBlockStringCompilation to upstream changes from the Trusted Types spec. For non timers this now goes through the motions of checking CSP for trusted types and doing neccessary enforcement.
unsafe-eval is left as is.
Preview | Diff