-
Notifications
You must be signed in to change notification settings - Fork 6
Editorial - WebDev SC Updates #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this huge update, it's clearly improved readability and nice to see things tidied up, great work!
I've added a number of comments, including some to drop criteria (sorry, hope that's okay in this stage still).
I saw the JSON before the HTML and added my comments there, can readd them to only the HTML if that's helpful.
One comment that I didn't find in the changeset; under goals of web development section, the first is:
Optimize code for accessibility, performance, security, and other impact targets.
I agree everyone should optimize for those things, but other than performance, I don't see how they map to what web developers can do about sustainability so would suggest to only performance here, or say something like “Optimize code for sustainability impact targets.”
This contains the editorial updates for the Web Development Success Criteria of the spec.
Some corrective changes from the original intent were made but these appear to be non-destructive and improve the quality and rationale behind the SC. Those of note are listed below:
Lead editorial credit: @codewordcreative
Helpful Note(s):
Further changes will likely be made/required to this content to ensure it meets measurability criteria, etc.
A preview of this pull request can be seen by clicking the diff button below and if you use the "full-document" link at the base of the spec you can navigate all the changes more easily using the available < and > buttons.
Preview | Diff