8000 Fix tilt to sperical calculation. by mustaqahmed · Pull Request #324 · w3c/pointerevents · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tilt to sperical calculation. #324

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Fix tilt to sperical calculation. #324

merged 1 commit into from
Jul 13, 2020

Conversation

mustaqahmed
Copy link
Member
@mustaqahmed mustaqahmed commented Jun 30, 2020 •
edited by pr-preview bot
Loading

Fix the calculation when tiltY == +-90.

Moreover, avoid possible problems with comparing (inexact) floating
point values by replacing radian comparisons with corresponding
(integer) degree comparisons.

Also avoided duplicate comparisons by replacing some |if|s with
|else if|s.

Preview | Diff

@mustaqahmed
Fix tilt to sperical calculation.
55a4d42 
Fix the calculation when tiltY == +-90.

Moreover, avoid possible problems with comparing (inexact) floating
point values by replacing radian comparisons with corresponding
(integer) degree comparisons.

Also avoided duplicate comparisons by replacing some |if|s with
|else if|s.
@mustaqahmed
Copy link
Member Author

@patrickhlauke and @liviutinta, ptal.

liviutinta
liviutinta approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor
@liviutinta liviutinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NavidZ NavidZ requested a review from patrickhlauke July 8, 2020 18:46
@patrickhlauke patrickhlauke merged commit 86672fe into w3c:gh-pages Jul 13, 2020
@mustaqahmed mustaqahmed removed the wpt label Nov 23, 2022
@mustaqahmed
Copy link
Member Author

This PR does not need a WPT: it updates an example only and does not change any normative text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@NavidZ NavidZ NavidZ approved these changes

@liviutinta liviutinta liviutinta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustaqahmed @patrickhlauke @NavidZ @liviutinta
0