Update azimuth/altitude/tiltX/tiltY to not require default values in pointer events web idl #323

liviutinta · 2020-05-28T16:11:52Z

Remove default values for tiltX,tiltY,azimuthAngle,altitudeAngle.
Change default value for altitudeAngle to π/2.
Describe rounding method for calculated tiltX,tiltY.
If only the value for one attribute is specified, the other attribute must be populated with the default value.
+@patrickhlauke
+@smaug----
+@NavidZ
+@domenic

Preview | Diff

…pointer events web interfaces Remove default values for `tiltX`,`tiltY`,`azimuthAngle`,`altitudeAngle`. Change default value for `altitudeAngle` to `π/2`. Describe rounding method for calculated `tiltX`,`tiltY`. If only the value for one attribute is specified, the other attribute must be populated with the default value.

NavidZ · 2020-06-04T00:16:37Z

index.html

+                            <p>The altitude (in radians) of the transducer (e.g. pen stylus), in the range [0,π/2] - where 0 is parallel to the surface (X-Y plane), and π/2 is perpendicular to the surface. For hardware and platforms that do not report tilt or angle, the value MUST be π/2.</p>
+                            <div class="note">
+                                When the hardware or platform does not report the tilt or angle, as opposed to the default value of 0 defined for <code>altitudeAngle</code>
+                                in <a href="https://w3c.github.io/touch-events/">Touch Events - Level 2</a> specification,


Just an editorial comment and not important really. You can also reference the touch events with brackets similar to other places in this spec so that it appear in the normative references.

I checked the reference database and there is no entry for Touch Events - Level 2. I believe this is why it is referenced like this here.

NavidZ · 2020-06-04T00:19:32Z

index.html

+                    If <code>azimuth</code> and <code>altitude</code> are provided, the user agent MUST initialize <code>tiltX</code>, <code>tiltY</code>
+                    with the calculated values rounded to the nearest integer value. For values falling exactly midway between integers, the user agend MUST always round up.
+                    </p>
+                    <p>If only the value of one of the two attributes is provided, the other attribute MUST be initialized to the default value.</p>


So does this line refer to both when out of 4 only 1 is present and when out of 4 only 3 is present?

So does this line refer to both when out of 4 only 1 is present and when out of 4 only 3 is present?

My intention was to cover both cases. Basically I would like to apply formulas only in these 2 cases:

(hasTiltX || hasTiltY) && !hasAzimuthAngle && !hasAltitudeAngle

(hasAzimuthAngle || hasAltitudeAngle) && !hasTiltX && !hasTiltY

If tiltX and tiltY and one of azimuthAngle/altitudeAngle values are provided, I cannot guarantee that azimuthAngle/altitudeAngle value as provided by the user matches the formula with regards to tiltX and tiltY. Same goes if azimuthAngle and altitudeAngle and one of tiltX/tiltY values are provided.

My assumption is that the user agent is not going to overwrite a value provided by the user. If the user provides values that are not correct it is an authoring problem.

NavidZ · 2020-06-04T00:20:51Z

@liviutinta btw, did this solve our implementation problem we see in Chromium code for "has*" functions?

liviutinta · 2020-06-04T21:06:53Z

@liviutinta btw, did this solve our implementation problem we see in Chromium code for "has*" functions?

Yes, removing default values for tiltX, tiltY, altitudeAngle, azimuthAngle in the pointer_event.idl and pointer_event_init.idl files solves the problem we've had with "has*" functions. Now, the functions work as I originally expected: for all properties in the set (tiltX, tiltY, altitudeAngle, azimuthAngle) with no value in the init dictionary the corresponding "has*" function returns false.

NavidZ

Sounds good to me.

mustaqahmed

This looks good but I would ask for a few minor edits.

index.html

Separate explanations for `tiltX` / `tiltY` and `altitudeAngle`/ `azimuthAngle` into 3 paragraphs: first a general description and how a user agent needs to populate trusted events, second about calculations for untrusted events and the last one a note related to rounding resulting `tiltX` / `tiltY` angles to degrees.

mustaqahmed

Thanks Liviu, this looks good to me now.

mustaqahmed · 2020-06-26T21:17:12Z

We will need approvals from @smaug---- and @patrickhlauke.

Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add tr 10000 ansform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6

Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6

Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6

NavidZ · 2020-07-08T18:47:42Z

@smaug---- and @patrickhlauke does this look okay?

Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6

Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165457 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790586}

Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165457 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790586}

…a=testonly Automatic update from web-platform-tests Add Azimuth/Altitude to Pointer Events Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165457 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790586} -- wpt-commits: 7a5f4a4eff43a231973fba9ba9527e1b88f54c74 wpt-pr: 23242

…a=testonly Automatic update from web-platform-tests Add Azimuth/Altitude to Pointer Events Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: w3c/pointerevents#323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165457 Reviewed-by: David Bokan <bokanchromium.org> Reviewed-by: Mustaq Ahmed <mustaqchromium.org> Commit-Queue: Liviu Tinta <liviutintachromium.org> Cr-Commit-Position: refs/heads/master{#790586} -- wpt-commits: 7a5f4a4eff43a231973fba9ba9527e1b88f54c74 wpt-pr: 23242 UltraBlame original commit: f438aea49eaefede895bbd0aeeecc6f5c42a721f

mustaqahmed · 2022-12-20T17:12:04Z

We have this WPT for this change: pointerevent_tiltX_tiltY_to_azimuth_altitude.html.

NavidZ reviewed Jun 4, 2020

View reviewed changes

NavidZ approved these changes Jun 5, 2020

View reviewed changes

NavidZ requested review from smaug---- and patrickhlauke June 23, 2020 23:24

mustaqahmed reviewed Jun 26, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

mustaqahmed approved these changes Jun 26, 2020

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Jun 26, 2020

Add Azimuth/Altitude to Pointer Events web-platform-tests/wpt#23242

Merged

patrickhlauke approved these changes Jul 13, 2020

View reviewed changes

patrickhlauke merged commit abf66fe into w3c:gh-pages Jul 13, 2020

patrickhlauke mentioned this pull request Jul 14, 2020

should altitudeAngle default to 0 or pi/2 when not supported? #320

Closed

liviutinta deleted the azimuth_altitude_no_default_in_idl branch July 14, 2020 19:08

liviutinta mentioned this pull request Jul 20, 2020

Pointer Events Azimuth Angle and Altitude Angle w3ctag/design-reviews#537

Closed

1 task

341A patrickhlauke added the wpt label Aug 17, 2022

mustaqahmed removed the wpt label Dec 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update azimuth/altitude/tiltX/tiltY to not require default values in pointer events web idl #323

Update azimuth/altitude/tiltX/tiltY to not require default values in pointer events web idl #323

Update azimuth/altitude/tiltX/tiltY to not require default values in pointer events web idl #323

Update azimuth/altitude/tiltX/tiltY to not require default values in pointer events web idl #323

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment