8000 Retry request abort the update by marcoscaceres · Pull Request #723 · w3c/payment-request · GitHub
[go: up one dir, main page]
Skip to content

Retry request abort the update #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoscaceres merged 6 commits into from
Jun 26, 2018
Merged

Retry request abort the update #723

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a73f331
Handle retry in abort the update algo
marcoscaceres Jun 11, 2018
0d9db1c
review feedback
marcoscaceres Jun 25, 2018
2660ab8
fixed note
marcoscaceres Jun 25, 2018
f1e52cc
fix dfn of [[complete]]
marcoscaceres Jun 25, 2018
c9aa022
typo
marcoscaceres Jun 25, 2018
9dffd8c
review nits
marcoscaceres Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed note
  • Loading branch information
@marcoscaceres
marcoscaceres committed Jun 25, 2018
commit 2660ab86d783e89201103da1fc4870ed0db7faa4
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4596,8 +4596,8 @@ <h2>
<p data-link-for="PaymentResponse">
Similarly, aborting the update occurs during a <a>retry()</a>, will
cause the <a>[[\retryPromise]]</a> to reject, and the corresponding
<a>PaymentRequest</a> is put into a "<a>complete</a>" state (i.e.,
meaning it can no longer be used).
<a>PaymentRequest</a>'s <a>[[\complete]]</a> internal slot will be
set to true (i.e., meaning it can no longer be used).
Copy link
Collaborator
@domenic domenic Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"i.e." and "meaning" seem redundant; pick one or the other.

</p>
</div>
</section>
Expand Down
0