8000 BREAKING CHANGE: remove `platform` from ManifestImageResource by christianliebel · Pull Request #913 · w3c/manifest · GitHub
[go: up one dir, main page]
Skip to content

BREAKING CHANGE: remove platform from ManifestImageResource #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2020
Merged

BREAKING CHANGE: remove platform from ManifestImageResource #913

merged 1 commit into from
Jul 6, 2020

Conversation

christianliebel
Copy link
Member
@christianliebel christianliebel commented Jul 6, 2020 •
edited by pr-preview bot
Loading

Closes #909

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

  • Safari (not implemented)
  • Chrome (not implemented)
  • Firefox (not implemented)
  • Edge (not implemented)

Commit message:

As pointed out in #909, the manifest provides other ways to adapt to platform conventions without explicitly stating a platform. Additionally, the property was never implemented by any browser.

Preview | Diff

@christianliebel christianliebel added the breaking Use for changes that break existing normative behavior label Jul 6, 2020
@christianliebel christianliebel force-pushed the drop-image-resource-platform branch 2 times, most recently from be4cf88 to 42fa7fe Compare July 6, 2020 08:17
marcoscaceres
marcoscaceres approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member
@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@christianliebel
BREAKING CHANGE: remove platform from ManifestImageResource
8000
d856bc6 
As pointed out in #909, the manifest provides other ways to adapt to platform conventions without explicitly stating a platform. Additionally, the property was never implemented by any browser.
@christianliebel christianliebel force-pushed the drop-image-resource-platform branch from 42fa7fe to d856bc6 Compare July 6, 2020 08:22
@marcoscaceres marcoscaceres merged commit 4ab46a2 into gh-pages Jul 6, 2020
@christianliebel christianliebel deleted the drop-image-resource-platform branch July 6, 2020 12:23
@mgiuca
Copy link
Collaborator
mgiuca commented Jul 8, 2020

Great, retroactive +1!

@mgiuca mgiuca mentioned this pull request Jul 10, 2020
Open
@marcoscaceres marcoscaceres mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
breaking Use for changes that break existing normative behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

At risk: ManifestImageResource.platform?
3 participants
@christianliebel @mgiuca @marcoscaceres
0