8000 Adding in some accessibility-related language by aarongustafson · Pull Request #898 · w3c/manifest · GitHub
[go: up one dir, main page]
Skip to content

Adding in some accessibility-related language #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 30, 2020
Merged

Adding in some accessibility-related language #898

merged 28 commits into from
Jun 30, 2020

Conversation

aarongustafson
Copy link
Collaborator
@aarongustafson aarongustafson commented Jun 9, 2020 •
edited by pr-preview bot
Loading

Closes #860

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

Taking a crack at adding accessibility info. The only outstanding item is adding a recommendation for screenshot labels once ImageResource is integrated.

Preview | Diff

marcoscaceres
marcoscaceres previously requested changes Jun 9, 2020
View reviewed changes
@marcoscaceres
Copy link
Member

Lookin good, but could also use a quick tidy 🙏

aarongustafson and others added 9 commits June 9, 2020 07:36
@aarongustafson @marcoscaceres
Removing hand-coded references
01b966f 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Language tweak
1d88868 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Update index.html
ce8a407 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Language update
abead2f 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Update index.html
baa42e9 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Update index.html
6f5d3d9 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson
Removed isolated sections for accessibility text
b84e5d9
@aarongustafson
Removing additional sections
bc95b50
@aarongustafson
Merge branch 'gh-pages' into accessibility-2020-06-08
e3c44f5
@aarongustafson
Copy link
Collaborator Author

@marcoscaceres I merged in the removed color processing steps too.

marcoscaceres
marcoscaceres reviewed Jun 10, 2020
View reviewed changes
aarongustafson
aarongustafson commented Jun 10, 2020
View reviewed changes
Copy link
Collaborator Author
@aarongustafson aarongustafson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes were resolved

marcoscaceres
marcoscaceres approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member
@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great... let's see if we can convince the A11y folks to export things properly :)

@marcoscaceres marcoscaceres added the BLOCKED Blocked for some reason label Jun 22, 2020
@marcoscaceres
Copy link
Member

Blocked on getting the A11y folk to export their definitions...

@aarongustafson
Copy link
Collaborator Author

@marcoscaceres I went old school on the definitions here to unblock merging this PR. Let me know if I missed anything. Respec isn’t complaining so it may be a good stopgap.

@aarongustafson aarongustafson removed the BLOCKED Blocked for some reason label Jun 29, 2020
marcoscaceres
marcoscaceres reviewed Jun 30, 2020
View reviewed changes
marcoscaceres
marcoscaceres reviewed Jun 30, 2020
View reviewed changes
marcoscaceres
marcoscaceres reviewed Jun 30, 2020
View reviewed changes
marcoscaceres
marcoscaceres reviewed Jun 30, 2020
View reviewed changes
aarongustafson and others added 2 commits June 29, 2020 17:35
@aarongustafson @marcoscaceres
Update index.html
5e61c7b 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson @marcoscaceres
Update index.html
51335ba 
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@aarongustafson aarongustafson merged commit d1699ec into w3c:gh-pages Jun 30, 2020
@aarongustafson aarongustafson deleted the accessibility-2020-06-08 branch June 30, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add accessibility section
2 participants
@aarongustafson @marcoscaceres
0