-
Notifications
You must be signed in to change notification settings - Fork 28
clarify output element naming #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f733d07
clarify output element naming
scottaohara 6a7341d
Update index.html
scottaohara 11591ad
further label step updates
scottaohara 36818e9
undo editorial update
scottaohara 7316819
Merge branch 'gh-pages' into output-naming
scottaohara e0b56e4
Merge branch 'gh-pages' into output-naming
scottaohara 9ba09a4
Merge branch 'gh-pages' into output-naming
scottaohara b24c8e0
Merge branch 'gh-pages' into output-naming
scottaohara ce7e914
Merge branch 'gh-pages' into output-naming
scottaohara 72ed696
Merge branch 'gh-pages' into output-naming
scottaohara 7af4464
Merge branch 'gh-pages' into output-naming
scottaohara a93c05e
Merge branch 'gh-pages' into output-naming
scottaohara a5421fd
Merge branch 'gh-pages' into output-naming
scottaohara 7d2c832
Merge branch 'gh-pages' into output-naming
scottaohara 500c86a
add relation info for output
scottaohara 44cb643
Merge branch 'gh-pages' into output-naming
scottaohara 088125b
Merge branch 'gh-pages' into output-naming
scottaohara 86aa398
Update index.html
scottaohara 4b0c53b
update changelog
scottaohara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add relation info for output
Adds into to output element mapping to align with other elements, such as fieldset, to indicate a labeling relationship.
- Loading branch information
commit 500c86a3760dcdcd5af391f06e679c6ca267075d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, pretty much all instances to
AXTitleorAXDescriptionshould be replaced withAXLabel. There was a legacy distinction in the original Mac OS X Accessibility Protocol that was later simplified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also may be worth considering whether to list these using a more common developer reference, like
accessibilityLabel. If @aleventhal or other non-Apple implementors have a preference, please advise. Thanks.https://developer.apple.com/documentation/objectivec/nsobject/1615181-accessibilitylabel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you object, @cookiecrook, I'm going to leave this as is since there's a larger find and replace issue I filed to fix this more broadly (#450).
That way, if this is instead changed to
accessibilityLabel, then this instance doesn't need to be changed again.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort of related, you should fix the missing backtick for AXDescription