This repository was archived by the owner on Jul 30, 2019. It is now read-only.
Referrer policy #954
Merged
Referrer policy #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointing out that use in the body can trigger unwanted side effects. See Issue w3c#544.
that this needs for completeness (attribute defs, IDL, etc.)
arronei
reviewed
Jun 23, 2017
| <a>removed from the document</a>, or existing <code>meta</code> elements have their <code>name</code> | ||
| or <code>content</code> attributes changed, user agents must run the following algorithm: | ||
|
|
||
| <ol> |
Contributor
There was a problem hiding this comment.
Could use the short hand ol list syntax.
arronei
previously requested changes
Jun 23, 2017
Contributor
There was a problem hiding this comment.
I have 2 comments but only the link wrapping one is necessary to correct. Once that is corrected anyone can merge this. The rest of this is fine.
|
|
||
| : <dfn><code>referrer</code></dfn> | ||
|
|
||
| :: The value must be a <a>referrer policy</a>, which defines the default <a>referrer |
Contributor
There was a problem hiding this comment.
Wrapping a link is bad. Could you fix this one link so we don't line break in the middle of an link element.
Author
|
Fixes for review are in d9217b6 - could someone check and merge please? |
chaals
approved these changes
Jul 5, 2017
Collaborator
There was a problem hiding this comment.
OK, this seems good to go now - thanks.
Alex seems to have made the change requested
plehegar
pushed a commit
that referenced
this pull request
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Issue #560 plus some manual diffs for referrerpolicy at various places in the spec. that weren't obvious from the issue.