8000 [css-shapes] link to closest-side definition by ewilligers · Pull Request #3911 · w3c/csswg-drafts · GitHub
[go: up one dir, main page]
Skip to content

[css-shapes] link to closest-side definition #3911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2019
Merged

[css-shapes] link to closest-side definition #3911

merged 1 commit into from
Aug 10, 2019

Conversation

ewilligers
Copy link
Contributor

Use ''closest-side'' syntax so the keyword is formatted as CSS syntax.
Use link-defaults to prevent definitions in css-images-3 or motion-1 from
being chosen by bikeshed.
Use <a href="#closest-side"> to link to the definition in CSS Shapes.

Note:
If basic shapes including the closest-side keyword were defined inside a
property such as shape-outside, we could use the
''shape-outide/closest-side'' bikeshed syntax.

@ewilligers ewilligers added the css-shapes-1 Current Work label May 10, 2019
@ewilligers ewilligers requested a review from tabatkins May 10, 2019 21:36
@ericwilligers
[css-shapes] link to closest-side definition
53cf13a 
Use ''closest-side'' syntax so the keyword is formatted as CSS syntax.
Use link-defaults to prevent definitions in css-images-3 or motion-1 from
being chosen by bikeshed.
Use `<a href="#closest-side">` to link to the definition in CSS Shapes.

Note:
If basic shapes including the closest-side keyword were defined inside a
property such as shape-outside, we could use the
''shape-outide/closest-side'' bikeshed syntax.
@ewilligers ewilligers requested a review from astearns May 24, 2019 00:21
@ewilligers
Copy link
Contributor Author

@tabatkins please review

@ewilligers ewilligers merged commit 7d64e7a into w3c:master Aug 10, 2019
@ewilligers ewilligers deleted the closest-side branch August 10, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabatkins tabatkins Awaiting requested review from tabatkins

@astearns astearns Awaiting requested review from astearns

Assignees
No one assigned
Labels
css-shapes-1 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewilligers @ericwilligers
0