Spelling & grammar markers #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astearns
approved these changes
Oct 16, 2017
css-text-decor-3/Overview.bs
Outdated
| <dt><dfn value for="text-tecoration-line">spelling-error</dfn> | ||
| <dd>This values indicates the type of text decoration used by the User Agent | ||
| to highlight spelling mistakes. | ||
| It's appearance is UA defined. |
css-text-decor-3/Overview.bs
Outdated
| Note that not blinking the text is one technique to satisfy <a href="https://www.w3.org/TR/UAAG/guidelines.html#tech-on-off-blinking-text">checkpoint 3.3 of WAI-UAAG</a>. | ||
| This value is <strong>deprecated</strong> in favor of Animations [[CSS3-ANIMATIONS]]. | ||
| <dt><dfn value for="text-tecoration-line">spelling-error</dfn> | ||
| <dd>This values indicates the type of text decoration used by the User Agent |
css-text-decor-3/Overview.bs
Outdated
| It's appearance is UA defined. | ||
| <span class=note>It is often rendered as a red wavy underline.</span> | ||
| <dt><dfn value for="text-decoration-line">grammar-error</dfn> | ||
| <dd>This values indicates the type of text decoration used by the User Agent |
css-text-decor-3/Overview.bs
Outdated
| <dt><dfn value for="text-decoration-line">grammar-error</dfn> | ||
| <dd>This values indicates the type of text decoration used by the User Agent | ||
| to highlight grammar mistakes. | ||
| It's appearance is UA defined. |
FremyCompany
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests is an attempt to solve #1828, based on what I think we were converging towards in during the conf call.
A possible variant of this would be to add the two new values to
text-decoration-styleinstead oftext-decoration-line. Arguably, if UAs wanted to allow it,text-decoration: overline spelling-erroris slightly more likely to be a meaningful combination thantext-decoration: solid spelling-error.However, neither are motivated by real use cases, and the syntax I chose in this PR means the feature can be activated with just
text-decoration: spelling-errorortext-decoration-line: spelling-error, rather than having to specifytext-decoration: spelling-error underline, expecting the underline part to be ignored, in order to avoid the longhand expansion totext-decoration-line: none; text-decoration-style: spelling-error;that would happen if it were left out.