[css-forms-1] Add ::file-selector-button to selectors for buttons
#11876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively I guess we can get this behaviour by removing all references to this pseudo except for a single rule. That way it will automatically get all of these styles because it's a button? ::file-selector-button {
appearance: base;
}Though that will require reflecting the enabled state of the file input to its internal button because currently that doesn't happen. |
nt1m
approved these changes
Mar 9, 2025
For future reference: no, because it's a pseudo-element. The fact that it's element-backed by a button doesn't let it match |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
::file-selector-buttonwould be missing many of the styles associated with button-like UI.