-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #978, add back ARIA element reflection IDL #1755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes (see whatwg/html#7934), we can add back these attributes to ARIA IDL. This is simply a revert of w3c#1260.
dakahn
approved these changes
Jun 30, 2022
jnurthen
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cookiecrook
approved these changes
Jul 1, 2022
@pkra, looks like this can be merged. Can it also be moved into |
jnurthen
added a commit
that referenced
this pull request
Aug 31, 2022
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes (see whatwg/html#7934), we can add back these attributes to ARIA IDL. This is simply a revert of #1260.
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes (see whatwg/html#7934), we can add back these attributes to ARIA IDL. This is simply a revert of #1260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that HTML spec defines reflection for Element and FrozenArray attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.
This is simply a revert of #1260.
💥 Error: 504 Gateway Timeout 💥
PR Preview failed to build. (Last tried on Jun 10, 2022, 4:27 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.