[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #978, add back ARIA element reflection IDL #1755

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

mrego
Copy link
Member
@mrego mrego commented Jun 10, 2022

Now that HTML spec defines reflection for Element and FrozenArray attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of #1260.


💥 Error: 504 Gateway Timeout 💥

PR Preview failed to build. (Last tried on Jun 10, 2022, 4:27 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

<html><body><h1>504 Gateway Time-out</h1>
The server didn't respond in time.
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of w3c#1260.
Copy link
Member
@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spectranaut
Copy link
Contributor

@pkra, looks like this can be merged. Can it also be moved into stable?

@pkra pkra merged commit 060b878 into w3c:main Jul 8, 2022
github-actions bot added a commit that referenced this pull request Jul 8, 2022
SHA: 060b878
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mrego mrego deleted the element-reflection branch July 8, 2022 08:47
@pkra pkra added this to the ARIA 1.3 milestone Jul 22, 2022
jnurthen added a commit that referenced this pull request Aug 31, 2022
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of #1260.
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
Now that HTML spec defines reflection for Element and FrozenArray<Element> attributes
(see whatwg/html#7934), we can add back these attributes to ARIA IDL.

This is simply a revert of #1260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants