Clarify build process #5
Merged
Conversation
This file cont
8000
ains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build and run instructions to README Add jar manifest Ignore .class and .jar files Remove compiled jar from repository
Owner
|
I'm presuming the reasons for not hosting the compiled program are security/trust related? |
Contributor
|
Compiled programs should be released as releases. |
Contributor
Author
|
My understanding is that git is primarily designed to manage text files, and also that compiled classes, binaries, and jars are redundant when the source is managed. Whenever you update the source, you'd have to either remember to recompile and commit those assets, or have a commit where the program doesn't match its source. |
Owner
|
I understand your reasoning, however I was providing it for convenience. Will try the release system instead. |
meetinger
referenced
this pull request
in meetinger/ArrayVisualizerOutdated
Apr 2, 2020
Clarify build process
meetinger
referenced
this pull request
in meetinger/ArrayVisualizerOutdated
Apr 12, 2020
Clarify build process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build and run instructions to README
Add jar manifest
Ignore .class and .jar files
Remove compiled jar from repository
Solution to issue #3, working off of @Skeen's changes