8000 feat(useFileDialog): add MaybRef to multiple, accept, capture, reset, and directory by hunterwilhelm · Pull Request #4813 · vueuse/vueuse · GitHub
[go: up one dir, main page]
Skip to content

feat(useFileDialog): add MaybRef to multiple, accept, capture, reset, and directory #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(useFileDialog): add MaybRef to multiple, accept, capture, reset, and directory #4813

wants to merge 1 commit into from

Conversation

hunterwilhelm
Copy link

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Fixes #4812

add MaybRef to multiple, accept, capture, reset, and directory

Additional context

These 5 parameters are only used upon invocation of open, so they can be easily updated using ref. The alternative was to rerender the entire component to update the composable.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 11, 2025
@MatthewAry
Copy link
MatthewAry commented Jun 11, 2025 •
edited
Loading

AMAZING LGTM!

@OrbisK
Copy link
Collaborator
OrbisK commented Jun 12, 2025

If we add this as MaybeRef we should also consider what we want to do it the ref updates

@hunterwilhelm
Copy link
Author

@OrbisK Already taken care of, it adds toValue everywhere they are being used, which happens to be all in the open function.

@OrbisK
Copy link
Collaborator
OrbisK commented Jun 13, 2025

@hunterwilhelm this is true, but we are not reacting if the ref value changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useFileDialog | Add reactivity to all of its props
3 participants
@hunterwilhelm @MatthewAry @OrbisK
0