8000 fix(onLongPress): honor `distanceThreshold` for touch devices by ssxv · Pull Request #4586 · vueuse/vueuse · GitHub
[go: up one dir, main page]
Skip to content

fix(onLongPress): honor distanceThreshold for touch devices #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(onLongPress): honor distanceThreshold for touch devices #4586

wants to merge 9 commits into from

Conversation

ssxv
Copy link
@ssxv ssxv commented Feb 14, 2025 •
edited
Loading

This PR solves onLongPress not honoring distanceThreshold parameter for touch devices.
(#4585)

  • Skiped touch events on existing listener functions.
  • Added listeners for touchstart, touchmove, touchend
  • Emit a custom event touchout if touch moves out of the element bound
  • Added listener for touchout

ssxv and others added 3 commits February 13, 2025 17:41
@ssxv
Update index.ts
e8b209e
@ssxv
add listeners for touchstart, touchmove, touchend
6cbbe27 
emit a custom event touchout if touch moves out of the element bound
add listener for touchout
@ssxv
Merge branch 'vueuse:main' into main
0756f75
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 14, 2025
@OrbisK
Copy link
Collaborator
OrbisK commented Feb 15, 2025

Can we cover this with tests?

@ssxv
Copy link
Author
ssxv commented Feb 16, 2025

Tests added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssxv @OrbisK
0