8000 feat(useRefHistory): add `shouldCommit` by JonathanSchndr · Pull Request #4471 · vueuse/vueuse · GitHub
[go: up one dir, main page]
Skip to content

feat(useRefHistory): add shouldCommit #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 10, 2025
Merged

feat(useRefHistory): add shouldCommit #4471

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
44d7d02
feat(UseRefHistoryOptions): add beforeCommit
JonathanSchndr Jan 7, 2025
b6d5abe
fix: type error
JonathanSchndr Jan 7, 2025
ca3bff7
refactor: rename beforeCommit to shouldCommit
JonathanSchndr Jan 10, 2025
6267cfe
feat: add test
JonathanSchndr Feb 3, 2025
7af045e
Merge branch 'main' into feat/UseRefHistoryOptions
JonathanSchndr May 2, 2025
96bed32
Merge branch 'main' into feat/UseRefHistoryOptions
antfu May 27, 2025
3ccddbc
Merge branch 'main' into feat/UseRefHistoryOptions
JonathanSchndr May 28, 2025
eb78a97
fix: lint errors
JonathanSchndr May 28, 2025
de3232c
refactor: oldValue to same type as newValue
JonathanSchndr May 28, 2025
fb461ee
fix: shouldCommit comparison to use raw values
JonathanSchndr May 29, 2025
56e27df
Update index.ts
JonathanSchndr Jun 7, 2025
122e6cc
Update packages/core/useRefHistory/index.ts
JonathanSchndr Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/core/useRefHistory/index.ts 
Co-authored-by: Robin <robin.kehl@singular-it.de>
  • Loading branch information
@JonathanSchndr @OrbisK
JonathanSchndr and OrbisK authored Jun 10, 2025
commit 122e6cc64ae3d5e53005adfa0d719e54dc0dd265
6 changes: 2 additions & 4 deletions packages/core/useRefHistory/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,8 @@ export function useRefHistory<Raw, Serialized = Raw>(
// so we do not trigger an extra commit in the async watcher
ignorePrevAsyncUpdates()

if (shouldCommit) {
if (!shouldCommit(lastRawValue, source.value))
return
}
if (!shouldCommit(lastRawValue, source.value))
return

lastRawValue = source.value
manualCommit()
Expand Down
0