8000 fix(makeDestructurable): fix Typescript < 5.0.0 support by brenoepics · Pull Request #4028 · vueuse/vueuse · GitHub
[go: up one dir, main page]
Skip to content

fix(makeDestructurable): fix Typescript < 5.0.0 support #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix(makeDestructurable): fix Typescript < 5.0.0 support #4028

merged 1 commit into from
Jun 11, 2024

Conversation

brenoepics
Copy link
Contributor
@brenoepics brenoepics commented Jun 9, 2024 •
edited by antfu
Loading

This reverts commit 4ea131a. (#3971),
Closes #4006, close #4023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

After our discussion at #4006 (comment),
we noticed that this commit broke VueUse's compatibility with TypeScript projects prior to version 5.0.0. Many developers, including myself, use frameworks that rely on TypeScript 4.x.x. Therefore, it might be beneficial to revert this change and issue a patch release. If const modifier on type parameters for makeDestructurable is deemed very important, we could have an alert or docs for minimum ts version, idk if ts 4.x.x is deprecated on vueuse

Additional context

Thank you to the maintainers for your hard work in keeping this project running smoothly despite the high volume of pull requests. Your dedication and efforts are greatly appreciated❤️

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 9, 2024
@antfu antfu merged commit 842d7c9 into vueuse:main Jun 11, 2024
7 checks passed
@antfu antfu mentioned this pull request Jun 11, 2024
Merged
5 tasks
This was referenced Jul 3, 2024
Open
Open
This was referenced Jul 24, 2024
Open
Open
@Samad2011s Samad2011s mentioned this pull request Jul 28, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 30, 2024
Open
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 18, 2024
Open
Open
Open
This was referenced Sep 21, 2024
Open
Open
This was referenced Sep 22, 2024
Open
Open
@renovate renovate bot mentioned this pull request Nov 27, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error The project packaging will report this TypeScript error.
2 participants
@brenoepics @antfu
0