feat: export ErrorWrapper
#1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
export `ErrorWrapper` so it can be used when extending VTU
|
Question: should dev/packages/test-utils/types/index.d.ts be updated for a change like this? Is there a way to generate typescript definitions, or are these manually maintained? |
|
Hi! The types are manually maintained (not exactly ideal). You can update them if you like. If you want to, let me know when you want to merge. If not, I can merge this now and prepare a release soon. |
|
@lmiller1990 thanks for the reply! I'm good with merging this as is. I'd be happy to help with the TypeScript definition later down the road if there is demand for it 🙂 |
|
I will do a release this week. |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
ErrorWrapperso it can be used when extending VTU.At GitLab we have an
extendedWrapperhelper that we use to add custom finders and matchers. We are trying to add some DOM testing library finders to ourextendedWrapperbut one problem we are running into isErrorWrapperis not exported so we have to do something like this. Ideally we would be able to doreturn new ErrorWrapper(query).What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: