8000 fix(ssr): memory leak in poll method by ronald-d-rogers · Pull Request #2875 · vuejs/vue-router · GitHub
[go: up one dir, main page]
Skip to content

fix(ssr): memory leak in poll method #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 6, 2020
Merged

fix(ssr): memory leak in poll method #2875

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e747d5e
fix(ssr): Memory leak in poll method, take 2 (fix #2606)
ronald-d-rogers Aug 7, 2019
062a5aa
fix: cb called before data init in keep-alive view and mixin guards n…
ronald-d-rogers Aug 8, 2019
71d0088
refactor: renamed things for clarity
ronald-d-rogers Aug 8, 2019
429a38c
fix: fixed bug from refactoring
ronald-d-rogers Aug 8, 2019
aff081e
refactor: a little bit more refactoring
ronald-d-rogers Aug 8, 2019
ecd71e7
fix: fixed enter cb not called in out-in transitions still
ronald-d-rogers Aug 9, 2019
f340981
chore(test): added coverage for out-in transition before route enter cb
ronald-d-rogers Aug 10, 2019
493ec47
fix: lint
ronald-d-rogers Aug 10, 2019
84b74ec
refactor: use one single component
posva Sep 23, 2019
0c8f65a
refactor: add back the isBeingDestroyed check
posva Sep 24, 2019
0bbf9dd
Merge branch 'dev' into fix#2606
posva May 24, 2020
e508744
Merge branch 'dev' into fix#2606
posva Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: add back the isBeingDestroyed check
  • Loading branch information
@posva
posva committed Sep 24, 2019
commit 0c8f65aa8fb5cff443bf700642898690fc11eac6
2 changes: 1 addition & 1 deletion src/util/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export function handleRouteEntered (route: Route) {
if (!instance || !cbs) continue
delete record.enteredCbs[name]
for (let i = 0; i < cbs.length; i++) {
cbs[i](instance)
if (!instance._isBeingDestroyed) cbs[i](instance)
}
}
}
Expand Down
0