8000 Bugfix/8.x webpack2 by yinheli · Pull Request #668 · vuejs/vue-loader · GitHub
[go: up one dir, main page]
Skip to content

Bugfix/8.x webpack2 #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2017
Merged

Bugfix/8.x webpack2 #668

merged 2 commits into from
Feb 23, 2017

Conversation

yinheli
Copy link
@yinheli yinheli commented Feb 22, 2017

解决 style 中指定 lang 兼容 webpack2 的问题

webpack2 配置下，制定 style 的 lang 属性，打包发生异常，异常信息如下：

> v-admin-framework@1.0.0 dev D:\workspace\work\water\v-admin-framework
> node demo/server.js

Server listening on http://127.0.0.1:9000, Ctrl+C to stop
D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\loadLoader.js:35
                        throw new Error("Module '" + loader.path + "' is not a loader (must have normal or pitch function)");
                        ^

Error: Module 'D:\workspace\work\water\v-admin-framework\node_modules\less\index.js' is not a loader (must have normal or pitch function)
    at loadLoader (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\loadLoader.js:35:10)
    at iteratePitchingLoaders (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:169:2)
    at iteratePitchingLoaders (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:165:10)
    at D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:173:18
    at loadLoader (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\loadLoader.js:36:3)
    at iteratePitchingLoaders (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:169:2)
    at iteratePitchingLoaders (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:165:10)
    at D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:173:18
    at loadLoader (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\loadLoader.js:36:3)
    at iteratePitchingLoaders (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:169:2)
    at runLoaders (D:\workspace\work\water\v-admin-framework\node_modules\loader-runner\lib\LoaderRunner.js:362:2)
    at NormalModule.doBuild (D:\workspace\work\water\v-admin-framework\node_modules\webpack\lib\NormalModule.js:129:2)
    at NormalModule.build (D:\workspace\work\water\v-admin-framework\node_modules\webpack\lib\NormalModule.js:180:15)
    at Compilation.buildModule (D:\workspace\work\water\v-admin-framework\node_modules\webpack\lib\Compilation.js:142:10)
    at factoryCallback (D:\workspace\work\water\v-admin-framework\node_modules\webpack\lib\Compilation.js:324:11)
    at D:\workspace\work\water\v-admin-framework\node_modules\webpack\lib\NormalModuleFactory.js:242:4

测试模板：

<template>
    <div class="layout">
        <!--
            // something
        -->
    </div>
</template>

<style lang="less" scoped>
  .layout {
    background: #f5f7f9;
    position: relative;
    min-width: 920px;
  }
</style>

通过指定 lang 为 less-loader 可以解决问题，但是这样处理看上去很别扭。

@yinheli
adapt for webpack2
32e5366 
loader suffix is no longer optional in webpack2 for clarity reasons
@see https://webpack.js.org/configuration/#options
@yinheli
fix tests, className failed in windows test
4da55ef 
className is not always start with "_"
@yinheli
Copy link
Author
yinheli commented Feb 22, 2017

我的组合式 vue1.x + webpack2， 部分项目还在使用 webpack1
感觉升级 webpack2 以后速度明显变快了。

用 vue1.x 是因为项目开始的比较早，现在比较复杂没精力升级了。

@kazupon kazupon requested a review from yyx990803 February 23, 2017 12:22
@yyx990803 yyx990803 merged commit ef39568 into vuejs:8.x Feb 23, 2017
@Sobcat
Copy link
Sobcat commented Mar 24, 2017

我也遇到这样的问题了，请问现在又解决方法了吗？

@yinheli
Copy link
Author
yinheli commented Mar 24, 2017

@laochunan 切到这个 8.x 分支就行了，问题修正，代码合并了

@qingtong234
Copy link

@yinheli 请问是怎么解决的呀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yinheli @Sobcat @qingtong234 @kazupon @yyx990803
0