8000 feat!: turn on modern mode by default, and provide a `--no-module` option by haoqunjiang · Pull Request #6416 · vuejs/vue-cli · GitHub
[go: up one dir, main page]
Skip to content

feat!: turn on modern mode by default, and provide a --no-module option #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 14, 2021
Merged

feat!: turn on modern mode by default, and provide a --no-module option #6416

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2726dca
test: add test for skipping safari nomodule fix injection
haoqunjiang Apr 8, 2021
1b21eb2
feat: only inject safari-nomodule-fix when necessary
haoqunjiang Apr 8, 2021
b079973
feat: modern mode on by default, and `--no-module` option
haoqunjiang Apr 9, 2021
7ec5c36
refactor: eliminate usage of `args.modern`
haoqunjiang Apr 9, 2021
1d55068
fix: fix the issues caused by the renaming from modern to module
haoqunjiang Apr 9, 2021
871d247
fix: compat with new `--no-module` flag
haoqunjiang Apr 13, 2021
1e764a1
fix: fix blur & focus event of the xterm
haoqunjiang Apr 13, 2021
2b60277
test: bump timeout
haoqunjiang Apr 13, 2021
5fb28f6
test: add test for `--no-module`
haoqunjiang Apr 13, 2021
5c96b0a
test: more thorough test for module build
haoqunjiang Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add test for --no-module
  • Loading branch information
@haoqunjiang
haoqunjiang committed Apr 13, 2021
commit 5fb28f6dc157b2a1325c0189435731838060b2bb
14 changes: 12 additions & 2 deletions packages/@vue/cli-service/__tests__/modernMode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,18 @@ test('should inject nomodule-fix script when Safari 10 support is required', asy
expect(index).not.toMatch(/[^>]\s*<\/script>/)
})

test.todo('--no-module')
test.todo('--no-modern as an alias to --no-module')
test('--no-module', async () => {
const project = await create('no-module', defaultPreset)

const { stdout } = await project.run('vue-cli-service build --no-module')
expect(stdout).toMatch('Build complete.')

const index = await project.read('dist/index.html')
expect(index).not.toMatch('type="module"')

const files = await fs.readdir(path.join(project.dir, 'dist/js'))
expect(files.some(f => /-legacy.js/.test(f))).toBe(false)
})

afterAll(async () => {
if (browser) {
Expand Down
0