feat!: support and use webpack 5 as default #6060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work-in-Progress TODOs: - Support opting-out to webpack 4 - Document the breaking changes - Fix the few remaining failing tests - Fix Vue 3 test setup (maybe in another PR) - Preload plugin should support html-webpack-plugin v4
webpack 4 compat is too cumbersome and let's forget about that for now
This avoids incorrect hoisting caused by vuepress sharing the vue-loader dependency, which falsely injects webpack v4 into the dependencies of vue-loader v15. Also added a hot fix for vue-cli-plugin-apollo
workbox-webpack-plugin upgraded from v4 to v6 alpha. Need further testing to make sure it works correctly. But for now, at least the existing tests have passed
36 tasks
from https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/ba3dbd71cec7becec0fbf529833204425f66efde/src/parseUtils.js to https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/4abac503c789bac94118e5bbfc410686fb5112c7/src/parseUtils.js excluding some of this commit: webpack-contrib/webpack-bundle-analyzer@c35bda3#diff-cc250993338f2c875d952782d3e6e5465c510ee355a68adb9f8f1ccd5d446823 as I don't find how this part of code logic fits into the DashboardPlugin. We may need a further refactor later.
In webpack 5, compilation.asset is a SizeOnlySource, so we have to read the source directly from the fs
It's a little bit tricky to update this plugin. So we'll reconsider it later.
note: dev server hmr is not working correctly
|
All tests are passing. I think it's ready for merge now! |
3 tasks
|
@sodatea What's the status of webpack-dev-server v4 support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-Progress
TODOs
resolutionsLater
Note
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: