8000 :pencil: docs: Set base property of VueRouter when deploying to gh-pages by anselal · Pull Request #5117 · vuejs/vue-cli · GitHub
[go: up one dir, main page]
Skip to content

📝 docs: Set base property of VueRouter when deploying to gh-pages #5117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2020
Merged

📝 docs: Set base property of VueRouter when deploying to gh-pages #5117

merged 3 commits into from
Feb 7, 2020

Conversation

anselal
Copy link
@anselal anselal commented Jan 29, 2020

When you use VueRouter and want to deploy to gh-pages (in a project) you have to set the base property of the VueRouter to the project's name

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@anselal
📝 docs: Set base property of VueRouter when deploying to gh-pages
ad0a7ee 
When you use VueRouter and want to deploy to gh-pages (in a project) you have to set the base property of the VueRouter to the project's name
@anselal
Fix small typo
844c0a2
pksunkara
pksunkara suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor
@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@NataliaTepluhina NataliaTepluhina merged commit 661b3c1 into vuejs:docs Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina left review comments

@pksunkara pksunkara pksunkara requested changes

Assignees
No one assigned
Labels
PR: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anselal @pksunkara @NataliaTepluhina @haoqunjiang
0