8000 feat: support custom package manager by zyy7259 · Pull Request #4621 · vuejs/vue-cli · GitHub
[go: up one dir, main page]
Skip to content

feat: support custom package manager #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 30, 2019
Merged

feat: support custom package manager #4621

merged 5 commits into from
Sep 30, 2019

Conversation

zyy7259
Copy link
Contributor
@zyy7259 zyy7259 commented Sep 26, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Turn Unknown package manager error into a warning and use the npm subcommands as fallbacks.

@zyy7259 zyy7259 mentioned this pull request Sep 26, 2019
Closed
haoqunjiang
haoqunjiang requested changes Sep 26, 2019
View reviewed changes
@zyy7259 zyy7259 requested a review from haoqunjiang September 26, 2019 14:01
haoqunjiang
haoqunjiang reviewed Sep 26, 2019
View reviewed changes
NataliaTepluhina
NataliaTepluhina reviewed Sep 28, 2019
View reviewed changes
Copy link
Member
@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also use chalk to emphasize not officially supported text?

@zyy7259
Copy link
Contributor Author
zyy7259 commented Sep 29, 2019

@sodatea @NataliaTepluhina How about this

      warn(
        `The package manager ${chalk.red(this.bin)} is ${chalk.red('not officially supported')}.\n` +
        `It will be treated like ${chalk.cyan('npm')}, but compatibility issues may occur.\n` +
        `See if you can use ${chalk.cyan('--registry')} instead.`
      )

image

@haoqunjiang
Copy link
Member

Looks good to me 😀

@haoqunjiang haoqunjiang merged commit 8869a01 into vuejs:dev Sep 30, 2019
@vue-bot
Copy link
vue-bot commented Sep 30, 2019

Hey @zyy7259, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@zyy7259 zyy7259 mentioned this pull request Dec 13, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina left review comments

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zyy7259 @haoqunjiang @vue-bot @NataliaTepluhina
0