10000 Detect yarn in Solus os by omarcresp · Pull Request #3942 · vuejs/vue-cli · GitHub
[go: up one dir, main page]
Skip to content

Detect yarn in Solus os #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Detect yarn in Solus os #3942

wants to merge 2 commits into from

Conversation

omarcresp
Copy link
@omarcresp omarcresp commented May 5, 2019 •
edited
Loading

@omarcresp omarcresp mentioned this pull request May 5, 2019
Closed
haoqunjiang
haoqunjiang requested changes May 11, 2019
View reviewed changes
Copy link
Member
@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I think we can just check for yarn command only, in that we never referred to yarnpkg anywhere else in the codebase.

pksunkara
pksunkara suggested changes Jun 25, 2019
View reviewed changes
@pksunkara
Copy link
Contributor

The main reason for using yarnpkg is that most of OS's give preference to Hadoop YARN when you call yarn

@omarcresp @pksunkara
Apply suggestions from code review
637d4c1 
suggest from @pksunkara

Co-Authored-By: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
@haoqunjiang
Copy link
Member
haoqunjiang commented Jul 3, 2019 •
edited
Loading

Hadoop YARN will throw for yarn --version (it only supports yarn version) so won't pass our check.

Since we run yarn rather than yarnpkg everywhere else, I think it makes sense to only check yarn.

@haoqunjiang haoqunjiang mentioned this pull request Jul 22, 2019
Merged
haoqunjiang added a commit th 8000 at referenced this pull request Jul 23, 2019
@haoqunjiang
fix: use yarn --version to detect yarn (#4336)
448dbdb 
- We never referred to `yarnpkg` anywhere else in the codebase
- For the rare case that `yarn` binary is overridden by Hadoop YARN,
`yarn --version` will throw (it only supports `yarn version`), therefore
it won't pass this check.

Fixes #3941.
Closes #3942.
haoqunjiang added a commit that referenced this pull request Aug 2, 2019
@haoqunjiang
fix: use yarn --version to detect yarn (#4336)
470c94e 
- We never referred to `yarnpkg` anywhere else in the codebase
- For the rare case that `yarn` binary is overridden by Hadoop YARN,
`yarn --version` will throw (it only supports `yarn version`), therefore
it won't pass this check.

Fixes #3941.
Closes #3942.

(cherry picked from commit 448dbdb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang requested changes

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
needs feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omarcresp @pksunkara @haoqunjiang
0