Warn user about Vue 2.x template. #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
- don't warn for webpack template since it's not yet in master/dist branch.
| @@ -12,7 +12,7 @@ var inquirer = require('inquirer') | |||
| var request = require('request') | |||
| var logger = require('../lib/logger') | |||
| var generate = require('../lib/generate') | |||
| var checkVersion = require('../lib/check-version') | |||
| var { checkVersion, warnForVue2Version } = require('../lib/check-version') | |||
There was a problem hiding this comment.
I love destructuring too, 😃 but it's unfortunately only available in Node 6+ and I believe we're supporting down to v4.
| @@ -36,3 +36,17 @@ module.exports = function (done) { | |||
| done() | |||
| }) | |||
| } | |||
|
|
|||
| function warnForVue2Version (template, name) { | |||
| var vue1InitCommand = 'vue init ' + template + '#1.0' + ' ' + name | |||
There was a problem hiding this comment.
Should we also pass in inPlace and then only show the name in the command if it's false?
|
@yyx990803 We're getting a fair amount of confusion with people not realising they're using Vue 2.0 by default in most templates now, so @zigomir came up with a fix. If possible, I think getting this out ASAP would really help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't yet warn for
webpacktemplate since 2.0 version is not yet released./cc @chrisvfritz