Add an isInPlace data to metadata completeMessage property
#125
Conversation
We test if a destination path is provided. If not, then we are scaffolding into the current directory and pass the `isCurrentDir` to `true`, if not, we set it to `false`.
isCurrentDir data to metadata completeMessage propertyisInPlace data to metadata completeMessage property
|
Hi @hugohil! Thanks for participating and sorry for not responding for so long here. As you can see, at this moment your PR has some conflicts with master branch. My general concern is if we really need another argument just to get a slightly better What do you think? |
|
@zigomir Thanks for the feedback ! I resolve conflicts and also avoided using this option as a new parameter for the For the tests, I just spend a some time trying to get one working without any luck (changing the cwd and still dealing with async got a bit tricky). I'll give it another shot later. |
| } else { | ||
| checkDistBranch(template, downloadAndGenerate) | ||
| } | ||
| checkDistBranch(template, downloadAndGenerate) |
There was a problem hiding this comment.
I think there should be no changes here in vue-init file. We shouldn't call checkDistBranch for every case because with that user can't specify the branch from which she/he wants to download template for.
|
@hugohil thanks! This looks better now. I left you few comments on |
| @@ -40,7 +40,8 @@ describe('vue-cli', () => { | |||
| sass: true | |||
| }, | |||
| pick: 'no', | |||
| noEscape: true | |||
| noEscape: true, | |||
| isInPlace: false | |||
There was a problem hiding this comment.
isInPlace isn't used anywhere else.
We test if a destination path is provided. If not, then we are scaffolding into the current directory and pass the
isCurrentDirtotrue, if not, we set it tofalse.