8000 feat: add warning when .native modifier is used on native HTML elements by NataliaTepluhina · Pull Request #9884 · vuejs/vue · GitHub
[go: up one dir, main page]
Skip to content

feat: add warning when .native modifier is used on native HTML elements #9884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2019
Merged

feat: add warning when .native modifier is used on native HTML elements #9884

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4f7f5a
feat: add test for checking native modifier
NataliaTepluhina Apr 16, 2019
c4d33fa
feat: add a warning on native modifier when used on elements
NataliaTepluhina Apr 17, 2019
ebc1283
fix: fixed a typo
NataliaTepluhina Apr 17, 2019
4eb3082
Update src/core/vdom/create-element.js
posva Apr 17, 2019
109fae2
Update test/unit/features/directives/on.spec.js
posva Apr 17, 2019
8aabed7
Update test/unit/features/directives/on.spec.js
sirlancelot Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/core/vdom/create-element.js 
Co-Authored-By: NataliaTepluhina <NataliaTepluhina@users.noreply.github.com>
  • Loading branch information
@posva @NataliaTepluhina
posva and NataliaTepluhina authored Apr 17, 2019
commit 4eb30822631b965e229702066f161f24395abde0
2 changes: 1 addition & 1 deletion src/core/vdom/create-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export function _createElement (
// platform built-in elements
if (process.env.NODE_ENV !== 'production' && isDef(data) && isDef(data.nativeOn)) {
warn(
`The .native modifier for v-on is only valid on components.`,
`The .native modifier for v-on is only valid on components but it was used on <${tag}>.`,
context
)
}
Expand Down
0