Support backspace with "delete" keycode alias #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
added a commit
that referenced
this pull request
Jan 22, 2016
…lete-alias Support backspace with "delete" keycode alias
|
Thanks for the detailed explanation and test coverage 👍 |
|
Glad to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the
deletealias in a on directive with keyup `delete" does not support using backspace. This seems quite counterintuitive. Additionally, on Mac keyboards the key normally identified as "backspace" on PC keyboards is called "delete." I was fairly surprised when using the delete modifier didn't detect the key.I came upon this when developing a search / tag field that turned a search query into tokens when hitting enter or space. I wanted a way to delete tokens without using the mouse. The solution I came up with was detecting the delete key and removing the last token if the search field was empty. I spent 10 minutes debugging code until I realized that I had to press fn+delete (equivalent of DEL / forward delete on a Mac laptop-sized keyboard) for it to actually remove the token.
You can see a reduced test case / demo of this here: http://codepen.io/thecrypticace/pen/YwGKmJ
This PR makes a change to allow aliases to map to multiple key codes. And, using that, it adds support for delete to react to both backspace and DEL / forward delete.