指令解析优化 #2196
Merged
指令解析优化 #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ import { | |||
| // special binding prefixes | |||
| const bindRE = /^v-bind:|^:/ | |||
| const onRE = /^v-on:|^@/ | |||
| const argRE = /:(.*)$/ | |||
| const dirAttrRE = /^v-([^:=]+)(?:$|:(.*)$)/ | |||
There was a problem hiding this comment.
attribute name 不可能有 = 号啊，为啥要避开 = 号
|
这里的代码是 1.0 时候逐步重构过来的，所以顺着那时候的思路就变这样了。用一个正则确实更简洁一些。多谢！ |
|
另外还请最终合并成一个 commit |
|
终于回滚正常了，抱歉，git用得不是很熟悉，给你添麻烦了。我马上修改下 |
|
你可以 git reset 到最后一个不属于你的 commit，然后重新 commit。之后 git push -f 到你的 fork 即可 |
|
好的 我试试 |
|
感谢。受教了。麻烦您抽空看看 |
yyx990803
added a commit
that referenced
this pull request
Jan 21, 2016
|
多谢，期待以后更多的 contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
您好。
您的代码非常精彩，分而治之的道理无处不在，以至于在第二遍阅读的时候任然感觉荡气回肠。
另外有个小问题：
在解析v-这种一般指令的时候为什么不用正则将指令名称和参数分离呢。