8000 `comparison.md` : Angular 1 to AngularJS and Angular 2 to Angular better consistency by MachinisteWeb · Pull Request #908 · vuejs/v2.vuejs.org · GitHub
[go: up one dir, main page]

Skip to content

comparison.md : Angular 1 to AngularJS and Angular 2 to Angular better consistency #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2017
Merged

comparison.md : Angular 1 to AngularJS and Angular 2 to Angular better consistency #908

merged 1 commit into from
May 16, 2017

Conversation

MachinisteWeb
Copy link
Contributor
@MachinisteWeb MachinisteWeb commented May 15, 2017

I follow the Evan intention when he used AngularJS and Angular (in title section) to speak about Angular 1 and Angular 2.

I proposed to really used the true term for each occurence for more consistency (the meaning link between AngularJS/Angular 1 and between Angular/Angular 2 was been etablishing in title section).

I proposed also to rewrite all webpack occurence with a minuscule letter as front because it is the official orthographe for « webpack » (without first letter capital, and also at the front of phrase https://webpack.github.io/docs/)

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>
@MachinisteWeb MachinisteWeb changed the title Angular 1 to AngularJS and Angular 2 to Angular comparison.md : Angular 1 to AngularJS and Angular 2 to Angular May 15, 2017
@MachinisteWeb MachinisteWeb changed the title comparison.md : Angular 1 to AngularJS and Angular 2 to Angular comparison.md : Angular 1 to AngularJS and Angular 2 to Angular better consistency May 15, 2017
Copy link
Member
@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazupon kazupon merged commit 5d6681e into vuejs:master May 16, 2017
@MachinisteWeb MachinisteWeb deleted the master_comparison branch May 18, 2017 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0