8000 Add new banner for Vuemastery free weekend by pieer · Pull Request #2512 · vuejs/v2.vuejs.org · GitHub
[go: up one dir, main page]
Skip to content

Add new banner for Vuemastery free weekend #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 5, 2020
Merged

Add new banner for Vuemastery free weekend #2512

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c5b0b45
Add Vue Mastery banner for free weekend lessons
pieer Feb 13, 2019
98a96e3
Add banner only on homepage
pieer Feb 13, 2019
4336b97
Add vuemastery weekend promo on every pages
pieer Feb 13, 2019
eff58be
Add vuemastery banner transition
pieer Feb 13, 2019
8fdde11
Fix platinium sponsor sidebar with vuemastery banner
pieer Feb 13, 2019
b725f67
Fix double line
pieer Feb 13, 2019
f021942
Remove banner animation and timeout
pieer Feb 13, 2019
5fd5baa
Add javascript after HTML content
pieer Feb 13, 2019
a07fc45
Optimise code on scroll with vue mastery banner
pieer Feb 14, 2019
8eaa956
Rename variable for better understanding
pieer Feb 14, 2019
b19ad3e
Rename vuemastery variables
pieer Feb 14, 2019
59ecdf1
Refactor code and remove unecessary wait for DOMContentLoaded
pieer Feb 14, 2019
1febd2f
Lint code
pieer Feb 14, 2019
2f3ff4a
Refactor, clean and lint code
pieer Feb 14, 2019
9711645
Fix menu position initialization
pieer Feb 14, 2019
abbb038
Remove unuecessary hardcoded position
pieer Feb 14, 2019
4dda4d1
Fix menu initialization
pieer Feb 14, 2019
0f97377
Clean code and comment
pieer Feb 14, 2019
fd6d3f2
Final refactor and fix closing button
pieer Feb 15, 2019
4a5d2f0
Merge remote-tracking branch 'upstream/master'
pieer Mar 4, 2020
0e57cfb
Add vue mastery new banner
pieer Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint code
  • Loading branch information
@pieer
pieer committed Feb 14, 2019
commit 1febd2fd318df4ca92b28520360857b78b4b49d7
11 changes: 5 additions & 6 deletions themes/vue/layout/partials/vuemastery_banner.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
(function () {
var elBody, elBanner, elClose, elMenu, posMenu, isMenuFixed;
var nameWrapper = 'vuemastery-weekend-promo';
var nameFixMenu = 'vuemastery-menu-fixed'
var nameStorage = 'vuemastery-banner'
var nameFixMenu = 'vuemastery-menu-fixed';
var nameStorage = 'vuemastery-banner';

var initBanner = function () {
// Get elements
Expand Down Expand Up @@ -49,15 +49,15 @@
elBody.classList.add(nameFixMenu);
isMenuFixed = true;
}
} else if(isMenuFixed) {
} else if (isMenuFixed) {
// The menu stay under the banner
elBody.classList.remove(nameFixMenu);
isMenuFixed = false;
}
}

var toggleBannerEvents = function (on) {
var method = on ? 'addEventListener' : 'removeEventListener'
var method = on ? 'addEventListener' : 'removeEventListener';
window[method]('resize', getMenuPosition);
window[method]('scroll', fixMenuAfterBanner);
}
Expand All @@ -76,12 +76,11 @@
elBody.classList.remove(nameWrapper);
}

// LOAD COMPONENT
// Check if user already removed the banner
if(!localStorage.getItem(nameStorage)) {
// Add event listeners
toggleBannerEvents(true);
// Wait for the DOM to be ready
// Load component
initBanner();
}
})()
Expand Down
0