8000 perf(typescript-plugin): re-implement subscription of component names and props by KazariEX · Pull Request #5329 · vuejs/language-tools · GitHub
[go: up one dir, main page]
Skip to content

perf(typescript-plugin): re-implement subscription of component names and props #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

perf(typescript-plugin): re-implement subscription of component names and props #5329

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8f86805
wip: re-implement subscription of component names and props
KazariEX Apr 19, 2025
579aec5
fix: do not use `Object.keys()` on `componentNames`
KazariEX Apr 19, 2025
b14a5b4
fix: update project version
KazariEX Apr 19, 2025
9ea5713
refactor: move `addVueCommands` into setup function
KazariEX Apr 19, 2025
e32234e
fix: initialize component props
KazariEX Apr 19, 2025
f3e6503
fix: initialize component names
KazariEX Apr 19, 2025
2a7074f
wip: add priority control to commands
KazariEX Apr 20, 2025
54db888
wip
KazariEX Apr 20, 2025
514fef7
wip
KazariEX Apr 20, 2025
a498ccb
fix: use `yes` or `no` as response of `vue:isProjectUpdated`
KazariEX Apr 20, 2025
435517e
fix: detect changes in node_modules
KazariEX Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: initialize component names
  • Loading branch information
@KazariEX
KazariEX committed Apr 19, 2025
commit f3e650395f539de52b106fa742660002b78ba27d
13 changes: 8 additions & 5 deletions packages/typescript-plugin/lib/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export function addVueCommands(
);
}

const data = getComponentInfo(scriptInfo.fileName);
let data = getComponentInfo(scriptInfo.fileName);
const [oldComponentNames, componentProps] = data;
const newComponentNames = getComponentNames.apply(requestContext, [scriptInfo.fileName]) ?? [];

Expand All @@ -98,10 +98,13 @@ export function addVueCommands(
}
}

function getComponentInfo(fileName: string) {
function getComponentInfo(fileName: string, initialize?: boolean) {
let data = componentInfos.get(fileName);
if (!data) {
componentInfos.set(fileName, data = [[], {}]);
componentInfos.set(fileName, data = [
initialize && getComponentNames.apply(getRequestContext(fileName), [fileName]) || [],
{}
]);
}
return data;
}
Expand All @@ -123,11 +126,11 @@ export function addVueCommands(
});
session.addProtocolHandler('vue:getComponentNames', ({ arguments: [fileName] }) => {
return {
response: getComponentInfo(fileName)[0],
response: getComponentInfo(fileName, true)[0],
};
});
session.addProtocolHandler('vue:getComponentProps', ({ arguments: [fileName, tag] }) => {
const [, componentProps] = getComponentInfo(fileName);
const [, componentProps] = getComponentInfo(fileName, true);
let response = componentProps[tag]
?? componentProps[camelize(tag)]
?? componentProps[capitalize(camelize(tag))];
Expand Down
Loading
0