8000 feat: support nested plugins by so1ve · Pull Request #3528 · vuejs/language-tools · GitHub
[go: up one dir, main page]

Skip to content

feat: support nested plugins #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

so1ve
Copy link
Member
@so1ve so1ve commented Sep 2, 2023

close #3437

/cc @sxzz

@so1ve
Copy link
Member Author
so1ve commented Sep 2, 2023

Ugh, seems plugin system will be rewritten in volar 2.0.

@@ -158,7 +158,7 @@ function getPartialVueCompilerOptions(
}
if (rawOptions.plugins) {
const plugins = rawOptions.plugins
.map<VueLanguagePlugin | undefined>((pluginPath: string) => {
.map<VueLanguagePlugin[] | VueLanguagePlugin | undefined>((pluginPath: string) => {
Copy link
Member
@sxzz sxzz Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting deep nested plugins will be even better. [a, [b, 8000 [c, d], e]]
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/config.ts#L128-L134

@so1ve so1ve marked this pull request as draft September 2, 2023 10:33
@so1ve so1ve closed this Sep 2, 2023
@so1ve so1ve deleted the feat/nested-plugins branch September 2, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested plugins
2 participants
0