8000 test: change defineComponent to support JSX by chakAs3 · Pull Request #3384 · vuejs/language-tools · GitHub
[go: up one dir, main page]
Skip to content

test: change defineComponent to support JSX #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2023
Merged

test: change defineComponent to support JSX #3384

merged 2 commits into from
Jul 13, 2023

Conversation

chakAs3
Copy link
Contributor
@chakAs3 chakAs3 commented Jul 8, 2023 •
edited
Loading

Function Signature ​

defineComponent() also has an alternative signature that is meant to be used with Composition API and render functions or JSX.

so I changed the test to match the new API and added test for JSX based component

// options syntax
function defineComponent(
  component: ComponentOptions
): ComponentConstructor

// function syntax (requires 3.3+)
function defineComponent(
  setup: ComponentOptions['setup'],
  extraOptions?: ComponentOptions
): () => any

@so1ve so1ve changed the title UnityTest: change defineComponent to support JSX test: change defineComponent to support JSX Jul 9, 2023
@johnsoncodehk johnsoncodehk merged commit a899685 into vuejs:master Jul 13, 2023
@johnsoncodehk
Copy link
Member

Thanks!

rchl added a commit to rchl/vue-language-tools that referenced this pull request Jul 13, 2023
@rchl
Merge remote-tracking branch 'origin/master' into fix/class-vue-2
bb3ea45 
* origin/master: (25 commits)
  chore: fix typo (vuejs#3399)
  chore: bump volar
  Deprecate language server `json.customBlockSchemaUrls` option (vuejs#3398)
  Use faster method after config change (vuejs#3393)
  test: change defineComponent to support JSX (vuejs#3384)
  fix(class references): non scoped classes resolution regression (vu
6ABE
ejs#3381)
  perf: hoist regexp if possible (vuejs#3378)
  fix: camel case components is not recognized as used (vuejs#3377)
  fix: allow slots to have no arguments (vuejs#3376)
  fix: don't remove comments when comment is in the first line (vuejs#3365)
  chore: add test for vuejs#3353
  chore: check project kind
  feat(typescript): implement `getExternalFiles`
  chore: update lock
  chore: remove resolve tsconfig warn
  ci(language-service): update html data
  chore: remove serverStats command from package.json of VSCode extension (vuejs#3366)
  v1.8.4
  chore: changelog
  chore: unpin volar
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chakAs3 @johnsoncodehk
0