8000 Change recommended links to js delivr by re-fort · Pull Request #360 · vuejs/jp.vuejs.org · GitHub
[go: up one dir, main page]

Skip to content

Change recommended links to js delivr #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2017

Conversation

re-fort
Copy link
Collaborator
@re-fort re-fort commented Oct 1, 2017

Cherry-picked from
vuejs/v2.vuejs.org@6a5b011

@re-fort re-fort requested a review from kazupon October 1, 2017 04:18
Copy link
Member
@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀しました!コメント 💬 の対応お願いします!:pray:

@@ -18,7 +18,7 @@ Vue (発音は / v j u ː / 、 **view** と同様)はユーザーインター
Vue.js を試すには、[JSFiddle Hello World example](https://jsfiddle.net/chrisvfritz/50wL7mdz/) が最も簡単です。自由に他のタブを開いて、基本的な例を試してみましょう。もしくは、単純に <a href="https://gist.githubusercontent.com/chrisvfritz/7f8d7d63000b48493c336e48b3db3e52/raw/ed60c4e5d5c6fec48b0921edaed0cb60be30e87c/index.html" target="_blank" download="index.html"><code>index.html</code> を作成し </a> 、以下のように Vue を含むことができます:

``` html
<script src="https://unpkg.com/vue"></script>
<script src="https://cdn.jsdelivr.net/npm/vue"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここですが、本家のこの PR で結局、unpkgに戻るので、unpkgのままにしてもらえますか?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘ありがとうございます!
戻しました!

gabor-farkas and others added 2 commits October 1, 2017 13:30
The other one results in `vue.common.js:245 Uncaught ReferenceError: process is not defined` while loading
Copy link
Member
@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@kazupon kazupon merged commit c8aff58 into vuejs:lang-ja Oct 1, 2017
@re-fort re-fort deleted the change-recommended-links-to-jsDelivr branch October 1, 2017 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0