8000 Add filename to example tsconfig.json by tricknotes · Pull Request #2365 · vuejs/jp.vuejs.org · GitHub
[go: up one dir, main page]
Skip to content

Add filename to example tsconfig.json #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

Add filename to example tsconfig.json #2365

merged 1 commit into from
Aug 4, 2021

Conversation

tricknotes
Copy link
Contributor
@tricknotes tricknotes commented Jul 10, 2021 •
edited
Loading

概要

元のリポジトリでは推奨環境の tsconfig.json の例にファイル名がコメントで記載されていましたが、日本語訳の方になかったので足しました。
https://github.com/vuejs/vuejs.org/blob/429fdee9b8264727664c782e31a19625c3af2a6e/src/v2/guide/typescript.md

補足

8f3fc8d の段階では記述されていましたが、 ae9659d によって意図せず消えてしまったのではと推測しています。

@tricknotes
Add filename to example tsconfig.json
2a140cf 
This filename has been written in the original markdown.
https://github.com/vuejs/vuejs.org/blob/429fdee9b8264727664c782e31a19625c3af2a6e/src/v2/guide/typescript.md

However, it was removed in ae9659d, maybe unexpectedly.
@kazupon
Copy link
Member
kazupon commented Aug 4, 2021

@tricknotes
大変遅くなりました！ありがとうございます！

@kazupon kazupon merged commit d0c2462 into vuejs:lang-ja Aug 4, 2021
@tricknotes
Copy link
Contributor Author

レビュー&マージありがとうございました!!

@tricknotes tricknotes deleted the patch-1 branch August 5, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tricknotes @kazupon
0