-
-
Notifications
You must be signed in to change notification settings - Fork 679
Add same order support on multiple types of attributes. #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub&rd 8000 quo;, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @tinymins Thanks for PR! Can you provide more informations about this change?
|
Thanks,
|
What's more, I have an other improvement idea for this rule. If an attribute's type is not listed in |
Alright @tinymins ! Thanks for clearing it out. I think that your case was covered in #421, as we got rid of If you however still want to ship support for grouping properties, I have to ask you to add tests covering the proposed enhancement - right here: https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/attributes-order.js |
Thanks, @michalsnik |
Hard to tell, maybe in week or two. Once we're done fixing current bugs and start preparing 5.0-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 GJ @tinymins
No description provided.