8000 Add new rule: vue/define-macros-order (#1855) by edikdeisling · Pull Request #1856 · vuejs/eslint-plugin-vue · GitHub
[go: up one dir, main page]
Skip to content

Add new rule: vue/define-macros-order (#1855) #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 21, 2022
Merged

Add new rule: vue/define-macros-order (#1855) #1856

merged 8 commits into from
Apr 21, 2022

Conversation

edikdeisling
Copy link
Contributor

No description provided.

@FloEdelmann FloEdelmann linked an issue Apr 19, 2022 that may be closed by this pull request
vue/define-macros-order #1855
Closed
edikdeisling
edikdeisling commented Apr 19, 2022
View reviewed changes
edikdeisling
edikdeisling commented Apr 19, 2022
View reviewed changes
FloEdelmann
FloEdelmann requested changes Apr 19, 2022
View reviewed changes
Copy link
Member
@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this suggestion and implementation. I've only done a preliminary review for now.

@edikdeisling
Copy link
Contributor Author

There are a few thoughts:

  1. Maybe it would be better to have defineEmitsFirst: true rather than order: ['defineEmits', 'defineProps']? Or there are maybe some other define* that could come in?
  2. Do we need to give an ability to specify a new line between these statements? newLineBetween: true

@FloEdelmann
Copy link
Member

Maybe it would be better to have defineEmitsFirst: true rather than order: ['defineEmits', 'defineProps']? Or there are maybe some other define* that could come in?

I like order better, as it mimics the option from the existing vue/order-in-components rule.

Do we need to give an ability to specify a new line between these statements?

I don't think that should be part of this rule.

FloEdelmann
FloEdelmann requested changes Apr 19, 2022
View reviewed changes
@FloEdelmann FloEdelmann mentioned this pull request Apr 19, 2022
Merged
FloEdelmann
FloEdelmann approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member
@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side! :)

@ota-meshi when reviewing, please have a look at these conversations:

@FloEdelmann FloEdelmann requested a review from ota-meshi April 19, 2022 14:11
8000
ota-meshi
ota-meshi requested changes Apr 20, 2022
View reviewed changes
Copy link
Member
@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I wrote some comments.

edikdeisling
edikdeisling commented Apr 20, 2022
View reviewed changes
ota-meshi
ota-meshi reviewed Apr 21, 2022
View reviewed changes
edikdeisling
edikdeisling commented Apr 21, 2022
View reviewed changes
ota-meshi
ota-meshi reviewed Apr 21, 2022
View reviewed changes
ota-meshi
ota-meshi approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member
@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 213042c into vuejs:master Apr 21, 2022
@edikdeisling
Copy link
Contributor Author

@ota-meshi I found a bug :(
This plugin breaks code with <script> and <script setup> tags in one file.

I'll create PR soon

@edikdeisling edikdeisling mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/define-macros-order
3 participants
@edikdeisling @FloEdelmann @ota-meshi
0