-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: enhance code block & code group #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hello maintainers (@bencodezen @yyx990803)! sorry for the pin, want to know what block this PR being merged? I'm happy to help. This plugin is very popular in the vitepress ecosystem. Projects's docs like And I think it will improve the Vue docs's readability too. |
There was a prob 8000 lem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuyinws Sorry for the delay in the review!
This looks like a great change. Appreciate the PR!
@yuyinws It looks like there's a merge-conflict with the lock file. Could you resolve it and push up the update? |
@bencodezen Hi, thanks for your review, I have resolved the conflict. |
Description of Problem
Current, the docs site use
<VTCodeGroup>
for define code groups.This PR use Vitepress' built-in
code-group
with vitepress-plugin-group-icons to replace it. which has automatic icon matching.Proposed Solution
Additional Information