8000 feat: enhance code block & code group by yuyinws · Pull Request #3235 · vuejs/docs · GitHub
[go: up one dir, main page]

Skip to content

feat: enhance code block & code group #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2025
Merged

Conversation

yuyinws
Copy link
Contributor
@yuyinws yuyinws commented May 14, 2025

Description of Problem

Current, the docs site use <VTCodeGroup> for define code groups.

This PR use Vitepress' built-in code-group with vitepress-plugin-group-icons to replace it. which has automatic icon matching.

Before After
image image
image image
image image

Proposed Solution

Additional Information

Copy link
netlify bot commented May 14, 2025

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 736a906
🔍 Latest deploy log https://app.netlify.com/projects/vuejs/deploys/685e07db266b40000814452f
😎 Deploy Preview https://deploy-preview-3235--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yuyinws
Copy link
Contributor Author
yuyinws commented Jun 3, 2025

Hello maintainers (@bencodezen @yyx990803)! sorry for the pin, want to know what block this PR being merged? I'm happy to help.

This plugin is very popular in the vitepress ecosystem. Projects's docs like vite, vitepress, vitest, unocss and so on are using it.

And I think it will improve the Vue docs's readability too.

Copy link
Member
@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuyinws Sorry for the delay in the review!

This looks like a great change. Appreciate the PR!

@bencodezen
Copy link
Member

@yuyinws It looks like there's a merge-conflict with the lock file. Could you resolve it and push up the update?

@bencodezen bencodezen added the state: blocked A label for merge requests where work is blocked label Jun 26, 2025
@yuyinws
Copy link
Contributor Author
yuyinws commented Jun 27, 2025

@bencodezen Hi, thanks for your review, I have resolved the conflict.

@yuyinws yuyinws requested a review from bencodezen June 27, 2025 02:57
@bencodezen bencodezen merged commit a3c31de into vuejs:main Jun 27, 2025
4 checks passed
AloisSeckar added a commit to AloisSeckar/vuejs-docs that referenced this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: blocked A label for merge requests where work is blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0