8000 docs: In-DOM Root Component Template does not support <script setup> by baiwusanyu-c · Pull Request #2385 · vuejs/docs · GitHub
[go: up one dir, main page]

Skip to content

docs: In-DOM Root Component Template does not support <script setup> #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

baiwusanyu-c
Copy link
Member
@baiwusanyu-c baiwusanyu-c commented May 29, 2023

Description of Problem

see:vuejs/core#8391

Proposed Solution

Use warnings to make documentation more explicit

Additional Information

@netlify
Copy link
netlify bot commented May 29, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 06c6831
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/649e962b2cf5b30008e2cb4a
😎 Deploy Preview https://deploy-preview-2385--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yyx990803
Copy link
Member

I don't think these are the right places to add the warning - it should probably be here https://vuejs.org/api/sfc-script-setup.html#script-setup

@baiwusanyu-c
Copy link
Member Author

I don't think these are the right places to add the warning - it should probably be here https://vuejs.org/api/sfc-script-setup.html#script-setup

ok i will fix it as soon as possible

7788
@NataliaTepluhina NataliaTepluhina merged commit 6d40f50 into vuejs:main Sep 20, 2023
@baiwusanyu-c baiwusanyu-c deleted the bwsy/docs/inDomAndSetup branch September 20, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0