8000 fix(ssr): ensure empty slots render as a comment node in Transition by edison1105 · Pull Request #13396 · vuejs/core · GitHub
[go: up one dir, main page]
Skip to content

fix(ssr): ensure empty slots render as a comment node in Transition #13396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 23, 2025
+125 −8
Merged

fix(ssr): ensure empty slots render as a comment node in Transition #13396

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a890378
fix(hydration): handle empty content in Transition appear edge case
edison1105 May 28, 2025
bd7d569
test: add test
edison1105 May 28, 2025
cd9735d
fix(hydration): handle empty <template> rendering by creating a comme…
edison1105 Jun 4, 2025
a95feba
fix(ssr): ensure empty slots render as comment nodes in hydration
edison1105 Jun 4, 2025
3f95d11
fix(ssr): handle empty slot rendering in ssrRenderSlotInner
edison1105 Jun 4, 2025
c4e3d00
test: add tests
edison1105 Jun 5, 2025
8f82270
fix(ssr): handle transition slots rendering by adding comment nodes
edison1105 Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(hydration): handle empty content in Transition appear edge case
  • Loading branch information
@edison1105
edison1105 committed May 28, 2025
commit a890378b5e9e02b469ee6c1e03540dc896ece122
3 changes: 2 additions & 1 deletion packages/runtime-core/src/hydration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,8 @@ export function createHydrationFunctions(
// replace node
const parentNode = oldNode.parentNode
if (parentNode) {
parentNode.replaceChild(newNode, oldNode)
if (newNode) parentNode.replaceChild(newNode, oldNode)
else remove(oldNode)
}

// update vnode
Expand Down
0