8000 chore(workflow): add TypeScript type checking step to CI by edison1105 · Pull Request #13367 · vuejs/core · GitHub
[go: up one dir, main page]
Skip to content

chore(workflow): add TypeScript type checking step to CI #13367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

chore(workflow): add TypeScript type checking step to CI #13367

merged 1 commit into from
May 22, 2025

Conversation

edison1105
Copy link
Member
@edison1105 edison1105 commented May 22, 2025 •
edited by coderabbitai bot
Loading

Dependencies auto-upgrade may cause some type incompatibility issues, such as 2c6c079

Summary by CodeRabbit

  • Chores
    • Updated automated workflow to include an additional type-checking step during testing.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 22, 2025 •
edited
Loading

Walkthrough

The workflow configuration file for GitHub Actions was updated to include a new step in the lint-and-test-dts job. This step, labeled "Run tsc," executes the pnpm run check command between the formatting and type declaration test steps.

Changes

File Change Summary
.github/workflows/test.yml Added a "Run tsc" step to the lint-and-test-dts job in the workflow.

Poem

In the warren of workflows, a new hop appears,
"Run tsc" now checks, allaying our fears.
Between pretty formats and types to attest,
Our code is now checked, and hops with the best!
🐇✨

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.3 kB 34.5 kB
vue.global.prod.js 159 kB 58.5 kB 52 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB 18.2 kB 16.7 kB
createApp 54.5 kB 21.2 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 20.9 kB
defineCustomElement 59.5 kB 22.8 kB 20.8 kB
overall 68.6 kB 26.4 kB 24.1 kB

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented May 22, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13367

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13367

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13367

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13367

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13367

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13367

@vue/runtime-dom

8000
npm i https://pkg.pr.new/@vue/runtime-dom@13367

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13367

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13367

vue

npm i https://pkg.pr.new/vue@13367

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13367

commit: 028e2d6

@edison1105 edison1105 force-pushed the edison/chore/tscCheck branch from 676d18b to 028e2d6 Compare May 22, 2025 03:51
@edison1105 edison1105 requested review from sxzz and johnsoncodehk May 22, 2025 03:52
sxzz
sxzz approved these changes May 22, 2025
View reviewed changes
Copy link
Member
@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coderabbitai[bot]
coderabbitai bot reviewed May 22, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/test.yml (1)

107-108: Add TypeScript type checking to CI
The new “Run tsc” step correctly invokes pnpm run check to catch type errors in the lint-and-test-dts job.
Please verify that the check script is defined in your package.json (e.g. tsc --noEmit or equivalent).
Consider caching TypeScript’s incremental build output (like .tsbuildinfo) or enabling --incremental to speed up repeated CI type-check runs.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c6c079 and 028e2d6.

📒 Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)

@edison1105 edison1105 merged commit 9fa787c into main May 22, 2025
16 checks passed
@edison1105 edison1105 deleted the edison/chore/tscCheck branch May 22, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sxzz sxzz sxzz approved these changes

@johnsoncodehk johnsoncodehk johnsoncodehk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edison1105 @sxzz @johnsoncodehk
0