8000 feat(custom-element): allow specifying additional options for `shadowRoot` in custom elements by padcom · Pull Request #12965 · vuejs/core · GitHub
[go: up one dir, main page]
Skip to content

feat(custom-element): allow specifying additional options for shadowRoot in custom elements #12965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(custom-element): allow specifying additional options for shadowRoot in custom elements #12965

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3262683
feat(runtime-dom): allow specifying additional options for attachShadow
padcom Feb 27, 2025
6380ae6
[autofix.ci] apply automated fixes
autofix-ci[bot] Feb 28, 2025
f50f535
feat(runtime-dom): ensure mode is always 'open' when attaching shadow…
padcom Feb 28, 2025
bcf27b2
[autofix.ci] apply automated fixes
autofix-ci[bot] Feb 28, 2025
416c35f
Merge branch 'main' into GH-12964
edison1105 May 19, 2025
468e729
Merge branch 'main' into GH-12964
padcom May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(runtime-dom): ensure mode is always 'open' when attaching shadow… 
…Root
  • Loading branch information
@padcom
padcom committed Mar 6, 2025
commit f50f53582aa7c3e75b9e87b0520ee02dccf2b86c
4 changes: 2 additions & 2 deletions packages/runtime-dom/src/apiCustomElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export type VueElementConstructor<P = {}> = {
export interface CustomElementOptions {
styles?: string[]
shadowRoot?: boolean
shadowRootOptions?: ShadowRootInit
shadowRootOptions?: Omit<ShadowRootInit, 'mode'>
nonce?: string
configureApp?: (app: App) => void
}
Expand Down Expand Up @@ -264,7 +264,7 @@ export class VueElement
)
}
if (_def.shadowRoot !== false) {
this.attachShadow(extend({ mode: 'open' }, _def.shadowRootOptions))
this.attachShadow(extend({}, _def.shadowRootOptions, { mode: 'open' }) as ShadowRootInit)
this._root = this.shadowRoot!
} else {
this._root = this
Expand Down
0