8000 fix(runtime-core): type ExposedKeys removed defined properties on com… by akotulu · Pull Request #12697 · vuejs/core · GitHub
[go: up one dir, main page]
Skip to content

fix(runtime-core): type ExposedKeys removed defined properties on com… #12697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix(runtime-core): type ExposedKeys removed defined properties on com… #12697

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
980cd03
fix(runtime-core): type ExposedKeys removed defined properties on com…
akotulu Jan 13, 2025
3fb85cf
test(runtime-core): fixed expose typing test
akotulu Jan 22, 2025
f8bfcee
Merge branch 'vuejs:main' into main
akotulu Jan 22, 2025
70fcd10
Merge branch 'main' of github.com:akotulu/core
akotulu Jan 22, 2025
d106429
Merge branch 'vuejs:main' into main
akotulu Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(runtime-core): fixed expose typing test
  • Loading branch information
@akotulu
akotulu committed Jan 22, 2025
commit 3fb85cf44321574b13ea696bbcb294583520e71c
11 changes: 7 additions & 4 deletions packages-private/dts-test/defineComponent.test-d.tsx
CE38 View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,7 @@ describe('expose typing', () => {
some: String,
},
data() {
return { a: 1, b: '2', c: 1 }
return { c: 1, d: '2', e: 1 }
},
})

Expand All @@ -1630,11 +1630,14 @@ describe('expose typing', () => {
// internal should still be exposed
vm.$props

expectType<number>(vm.a)
expectType<string>(vm.b)
expectType<number>(vm.c)
expectType<string>(vm.d)
expectType<number>(vm.e)

// @ts-expect-error shouldn't be exposed
vm.c
vm.a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not proper, both a and b should be exposed, see line 1618.

// @ts-expect-error shouldn't be exposed
vm.b
})

import type {
Expand Down
0